Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/acctest: update to aws_s3_bucket_acl #23078

Merged
merged 1 commit into from
Feb 9, 2022
Merged

tests/acctest: update to aws_s3_bucket_acl #23078

merged 1 commit into from
Feb 9, 2022

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Feb 9, 2022 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #22997
Relates #22537
Relates #20433

Output from acceptance testing:

--- PASS: TestAccAcctestProvider_Region_awsCommercial (21.93s)
--- PASS: TestAccAcctestProvider_Region_awsC2S (21.94s)
--- PASS: TestAccAcctestProvider_Region_awsGovCloudUs (22.46s)
--- PASS: TestAccAcctestProvider_Region_awsChina (22.81s)
--- PASS: TestAccAcctestProvider_Region_awsSC2S (22.85s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one (27.28s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_one (27.29s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none (27.53s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_multiple (27.56s)
--- PASS: TestAccAcctestProvider_IgnoreTags_emptyBlock (28.03s)
--- PASS: TestAccAcctestProvider_unusualEndpoints (28.05s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_multiple (28.05s)
--- PASS: TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks (28.05s)
--- PASS: TestAccAcctestProvider_DefaultTags_emptyBlock (28.05s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_none (28.05s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_none (28.06s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple (28.20s)
--- PASS: TestAccAcctestProvider_endpoints (28.60s)
--- PASS: TestAccAcctestProvider_AssumeRole_empty (30.69s)
--- PASS: TestAccAcctestProvider_DefaultTagsTags_one (10.44s)
--- PASS: TestAccAcctestProvider_fipsEndpoint (45.44s)

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Feb 9, 2022
@anGie44 anGie44 added this to the v4.0.0 milestone Feb 9, 2022
@anGie44 anGie44 marked this pull request as ready for review February 9, 2022 19:43
@anGie44 anGie44 mentioned this pull request Feb 9, 2022
Merged
ewbankkit
ewbankkit approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccAcctestProvider_' PKG_NAME=internal/acctest ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/acctest/... -v -count 1 -parallel 3  -run=TestAccAcctestProvider_ -timeout 180m
=== RUN   TestAccAcctestProvider_DefaultTags_emptyBlock
=== PAUSE TestAccAcctestProvider_DefaultTags_emptyBlock
=== RUN   TestAccAcctestProvider_DefaultTagsTags_none
=== PAUSE TestAccAcctestProvider_DefaultTagsTags_none
=== RUN   TestAccAcctestProvider_DefaultTagsTags_one
=== PAUSE TestAccAcctestProvider_DefaultTagsTags_one
=== RUN   TestAccAcctestProvider_DefaultTagsTags_multiple
=== PAUSE TestAccAcctestProvider_DefaultTagsTags_multiple
=== RUN   TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks
=== PAUSE TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks
=== RUN   TestAccAcctestProvider_endpoints
=== PAUSE TestAccAcctestProvider_endpoints
=== RUN   TestAccAcctestProvider_fipsEndpoint
=== PAUSE TestAccAcctestProvider_fipsEndpoint
=== RUN   TestAccAcctestProvider_unusualEndpoints
=== PAUSE TestAccAcctestProvider_unusualEndpoints
=== RUN   TestAccAcctestProvider_IgnoreTags_emptyBlock
=== PAUSE TestAccAcctestProvider_IgnoreTags_emptyBlock
=== RUN   TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none
=== PAUSE TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none
=== RUN   TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one
=== PAUSE TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one
=== RUN   TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple
=== PAUSE TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple
=== RUN   TestAccAcctestProvider_IgnoreTagsKeys_none
=== PAUSE TestAccAcctestProvider_IgnoreTagsKeys_none
=== RUN   TestAccAcctestProvider_IgnoreTagsKeys_one
=== PAUSE TestAccAcctestProvider_IgnoreTagsKeys_one
=== RUN   TestAccAcctestProvider_IgnoreTagsKeys_multiple
=== PAUSE TestAccAcctestProvider_IgnoreTagsKeys_multiple
=== RUN   TestAccAcctestProvider_Region_awsC2S
=== PAUSE TestAccAcctestProvider_Region_awsC2S
=== RUN   TestAccAcctestProvider_Region_awsChina
=== PAUSE TestAccAcctestProvider_Region_awsChina
=== RUN   TestAccAcctestProvider_Region_awsCommercial
=== PAUSE TestAccAcctestProvider_Region_awsCommercial
=== RUN   TestAccAcctestProvider_Region_awsGovCloudUs
=== PAUSE TestAccAcctestProvider_Region_awsGovCloudUs
=== RUN   TestAccAcctestProvider_Region_awsSC2S
=== PAUSE TestAccAcctestProvider_Region_awsSC2S
=== RUN   TestAccAcctestProvider_AssumeRole_empty
=== PAUSE TestAccAcctestProvider_AssumeRole_empty
=== CONT  TestAccAcctestProvider_DefaultTags_emptyBlock
=== CONT  TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple
=== CONT  TestAccAcctestProvider_fipsEndpoint
--- PASS: TestAccAcctestProvider_DefaultTags_emptyBlock (7.94s)
=== CONT  TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_multiple (7.96s)
=== CONT  TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_none (5.33s)
=== CONT  TestAccAcctestProvider_IgnoreTags_emptyBlock
--- PASS: TestAccAcctestProvider_IgnoreTagsKeyPrefixes_one (5.40s)
=== CONT  TestAccAcctestProvider_unusualEndpoints
--- PASS: TestAccAcctestProvider_IgnoreTags_emptyBlock (5.35s)
=== CONT  TestAccAcctestProvider_DefaultTagsTags_multiple
--- PASS: TestAccAcctestProvider_unusualEndpoints (5.64s)
=== CONT  TestAccAcctestProvider_endpoints
--- PASS: TestAccAcctestProvider_DefaultTagsTags_multiple (5.37s)
=== CONT  TestAccAcctestProvider_Region_awsChina
--- PASS: TestAccAcctestProvider_endpoints (5.79s)
=== CONT  TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks
--- PASS: TestAccAcctestProvider_Region_awsChina (4.60s)
=== CONT  TestAccAcctestProvider_AssumeRole_empty
--- PASS: TestAccAcctestProvider_DefaultAndIgnoreTags_emptyBlocks (6.19s)
=== CONT  TestAccAcctestProvider_DefaultTagsTags_one
--- PASS: TestAccAcctestProvider_fipsEndpoint (33.62s)
=== CONT  TestAccAcctestProvider_Region_awsSC2S
--- PASS: TestAccAcctestProvider_DefaultTagsTags_one (5.43s)
=== CONT  TestAccAcctestProvider_DefaultTagsTags_none
--- PASS: TestAccAcctestProvider_Region_awsSC2S (4.34s)
=== CONT  TestAccAcctestProvider_Region_awsCommercial
--- PASS: TestAccAcctestProvider_AssumeRole_empty (13.09s)
=== CONT  TestAccAcctestProvider_Region_awsGovCloudUs
--- PASS: TestAccAcctestProvider_DefaultTagsTags_none (5.95s)
=== CONT  TestAccAcctestProvider_IgnoreTagsKeys_multiple
--- PASS: TestAccAcctestProvider_Region_awsCommercial (4.70s)
=== CONT  TestAccAcctestProvider_IgnoreTagsKeys_one
--- PASS: TestAccAcctestProvider_Region_awsGovCloudUs (5.03s)
=== CONT  TestAccAcctestProvider_Region_awsC2S
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_multiple (6.49s)
=== CONT  TestAccAcctestProvider_IgnoreTagsKeys_none
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_one (6.61s)
--- PASS: TestAccAcctestProvider_Region_awsC2S (4.88s)
--- PASS: TestAccAcctestProvider_IgnoreTagsKeys_none (5.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/acctest	57.945s

@anGie44 anGie44 merged commit 5788c64 into main Feb 9, 2022
@anGie44 anGie44 deleted the td-acctest-s3-bucket-acl branch February 9, 2022 20:55
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anGie44 @ewbankkit